Re: [PATCH] drm/amdgpu: correct comments in memory type managers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Am 26.08.21 um 11:59 schrieb Yifan Zhang:
Signed-off-by: Yifan Zhang <yifan1.zhang@xxxxxxx>

At least a one line commit message would be nice. Something like "The parameter was renamed."

With that done the patch is Reviewed-by: Christian König <christian.koenig@xxxxxxx>.

Regards,
Christian.

---
  drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c  | 4 ++--
  drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 6 +++---
  2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c
index ec96e0b26b11..c18f16b3be9c 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c
@@ -118,7 +118,7 @@ bool amdgpu_gtt_mgr_has_gart_addr(struct ttm_resource *res)
   * @man: TTM memory type manager
   * @tbo: TTM BO we need this range for
   * @place: placement flags and restrictions
- * @mem: the resulting mem object
+ * @res: the resulting mem object
   *
   * Dummy, allocate the node but no space for it yet.
   */
@@ -184,7 +184,7 @@ static int amdgpu_gtt_mgr_new(struct ttm_resource_manager *man,
   * amdgpu_gtt_mgr_del - free ranges
   *
   * @man: TTM memory type manager
- * @mem: TTM memory object
+ * @res: TTM memory object
   *
   * Free the allocated GTT again.
   */
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
index 2fd77c36a1ff..7b2b0980ec41 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
@@ -361,7 +361,7 @@ static void amdgpu_vram_mgr_virt_start(struct ttm_resource *mem,
   * @man: TTM memory type manager
   * @tbo: TTM BO we need this range for
   * @place: placement flags and restrictions
- * @mem: the resulting mem object
+ * @res: the resulting mem object
   *
   * Allocate VRAM for the given BO.
   */
@@ -487,7 +487,7 @@ static int amdgpu_vram_mgr_new(struct ttm_resource_manager *man,
   * amdgpu_vram_mgr_del - free ranges
   *
   * @man: TTM memory type manager
- * @mem: TTM memory object
+ * @res: TTM memory object
   *
   * Free the allocated VRAM again.
   */
@@ -522,7 +522,7 @@ static void amdgpu_vram_mgr_del(struct ttm_resource_manager *man,
   * amdgpu_vram_mgr_alloc_sgt - allocate and fill a sg table
   *
   * @adev: amdgpu device pointer
- * @mem: TTM memory object
+ * @res: TTM memory object
   * @offset: byte offset from the base of VRAM BO
   * @length: number of bytes to export in sg_table
   * @dev: the other device




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux