RE: [PATCH] drm/amd/pm: Add waiting for response of mode-reset message for yellow carp

["Quan, Evan" <Evan.Quan@xxxxxxx>]

[AMD Official Use Only]

Reviewed-by: Evan Quan <evan.quan@xxxxxxx>

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of
> Aaron Liu
> Sent: Tuesday, July 13, 2021 3:01 PM
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Huang, Ray
> <Ray.Huang@xxxxxxx>; Liu, Aaron <Aaron.Liu@xxxxxxx>
> Subject: [PATCH] drm/amd/pm: Add waiting for response of mode-reset
> message for yellow carp
> 
> Remove mdelay process and use smu_cmn_send_smc_msg_with_param to
> send mode-reset message to SMC.
> 
> Signed-off-by: Aaron Liu <aaron.liu@xxxxxxx>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c
> b/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c
> index de92f713a911..0cfeb9fc7c03 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c
> @@ -298,13 +298,9 @@ static int yellow_carp_mode_reset(struct
> smu_context *smu, int type)
>  	if (index < 0)
>  		return index == -EACCES ? 0 : index;
> 
> -	mutex_lock(&smu->message_lock);
> -
> -	ret = smu_cmn_send_msg_without_waiting(smu, (uint16_t)index,
> type);
> -
> -	mutex_unlock(&smu->message_lock);
> -
> -	mdelay(10);
> +	ret = smu_cmn_send_smc_msg_with_param(smu, (uint16_t)index,
> type, NULL);
> +	if (ret)
> +		dev_err(smu->adev->dev, "Failed to mode reset!\n");
> 
>  	return ret;
>  }
> --
> 2.25.1
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.
> freedesktop.org%2Fmailman%2Flistinfo%2Famd-
> gfx&amp;data=04%7C01%7Cevan.quan%40amd.com%7C1045fee1435a4b49d
> 1ae08d945cc0427%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63
> 7617564811709038%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMD
> AiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=
> FSmq1fObJ5x2Yl86ZWsGpr7SZPju6o4CZYyPp2xBZOs%3D&amp;reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx