[AMD Official Use Only] Reviewed-by: Huang Rui <ray.huang@xxxxxxx> -----Original Message----- From: Liu, Aaron <Aaron.Liu@xxxxxxx> Sent: Wednesday, June 30, 2021 1:57 PM To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Huang, Ray <Ray.Huang@xxxxxxx>; Gong, Curry <Curry.Gong@xxxxxxx>; Kuehling, Felix <Felix.Kuehling@xxxxxxx>; Liu, Aaron <Aaron.Liu@xxxxxxx>; Huang, Ray <Ray.Huang@xxxxxxx> Subject: [PATCH] drm/amdgpu: Make noretry the default on yellow carp From: chen gong <curry.gong@xxxxxxx> Performing kfd page fault tests on the yellow carp platform will fail. >From the scan data after the failure, it can be found that a nack=0x1(retry fault) is returned. but we did not enable the interrupts for retry faults in the code. So we need to set noretry = 1 like the above ASICs. Signed-off-by: chen gong <curry.gong@xxxxxxx> Reviewed-by: Aaron Liu <aaron.liu@xxxxxxx> Acked-by: Huang Rui <ray.huang@xxxxxxx> --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c index 1525d957e114..d4e9704dec62 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c @@ -591,6 +591,7 @@ void amdgpu_gmc_noretry_set(struct amdgpu_device *adev) case CHIP_ARCTURUS: case CHIP_ALDEBARAN: case CHIP_BEIGE_GOBY: + case CHIP_YELLOW_CARP: /* * noretry = 0 will cause kfd page fault tests fail * for some ASICs, so set default to 1 for these ASICs. -- 2.25.1 _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
