On 2021-06-28 1:36 p.m., Alex Deucher wrote: > On Mon, Jun 28, 2021 at 1:26 PM Luben Tuikov <luben.tuikov@xxxxxxx> wrote: >> Fix controller port setting of Navi10 from 1 >> (incorrect) to 0 (correct). >> >> This fixes a previous rework commit which >> introduced this typo. >> >> Cc: Alexander Deucher <Alexander.Deucher@xxxxxxx> >> Signed-off-by: Luben Tuikov <luben.tuikov@xxxxxxx> > For patches 2 and 3, please add a Fixes: line to id the commit these > fix. With those added, the series is: > Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx> Yes, great--will do. (I was debating this when crafting the patch descriptions... Thanks for the confirmation! :-) ) Regards, Luben > >> --- >> drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c >> index 205dc2e56ab199..36264b78199620 100644 >> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c >> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c >> @@ -2749,7 +2749,7 @@ static int navi10_i2c_xfer(struct i2c_adapter *i2c_adap, >> if (!req) >> return -ENOMEM; >> >> - req->I2CcontrollerPort = 1; >> + req->I2CcontrollerPort = 0; >> req->I2CSpeed = I2C_SPEED_FAST_400K; >> req->SlaveAddress = msg[0].addr << 1; /* wants an 8-bit address */ >> dir = msg[0].flags & I2C_M_RD; >> -- >> 2.32.0 >> >> _______________________________________________ >> amd-gfx mailing list >> amd-gfx@xxxxxxxxxxxxxxxxxxxxx >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Cluben.tuikov%40amd.com%7C296fe43070f541cf9a5008d93a5b55fc%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637604986221909193%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=133unYfZMpoNI76MVZMh6W%2FsBsHMOR2A8F6MHwRqP%2BA%3D&reserved=0 _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
