On 2021-06-16 10:31 p.m., Pu Lehui wrote: > GCC reports the following warning with W=1: > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3635:17: > warning: > variable ‘status’ set but not used [-Wunused-but-set-variable] > 3635 | enum dc_status status = DC_ERROR_UNEXPECTED; > | ^~~~~~ > > The variable should be used for error check, let's fix it. > > Signed-off-by: Pu Lehui <pulehui@xxxxxxxxxx> Reviewed-by: Harry Wentland <harry.wentland@xxxxxxx> Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c > index fcb635c85330..cf29265870c8 100644 > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c > @@ -3681,6 +3681,10 @@ bool dp_retrieve_lttpr_cap(struct dc_link *link) > DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV, > lttpr_dpcd_data, > sizeof(lttpr_dpcd_data)); > + if (status != DC_OK) { > + dm_error("%s: Read LTTPR caps data failed.\n", __func__); > + return false; > + } > > link->dpcd_caps.lttpr_caps.revision.raw = > lttpr_dpcd_data[DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV - > _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx