[AMD Official Use Only - Internal Distribution Only] Hi Das&Christian, Merged. Thanks you both for the comments. --Brs, Morris Zhang MLSE Linux ML SRDC Ext. 25147 -----Original Message----- From: Christian König <ckoenig.leichtzumerken@xxxxxxxxx> Sent: Wednesday, May 26, 2021 8:44 PM To: Zhang, Morris <Shiwu.Zhang@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Das, Nirmoy <Nirmoy.Das@xxxxxxx> Subject: Re: [PATCH] free the metadata buffer for sg type BOs as well You need a commit message. Am 26.05.21 um 05:46 schrieb Shiwu Zhang: > Signed-off-by: Shiwu Zhang <shiwu.zhang@xxxxxxx> With that fixed the patch is Reviewed-by: Christian König <christian.koenig@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > index 2d876e1eaa7c..e9f8701fd046 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > @@ -95,7 +95,7 @@ static void amdgpu_bo_destroy(struct ttm_buffer_object *tbo) > } > amdgpu_bo_unref(&bo->parent); > > - if (bo->tbo.type == ttm_bo_type_device) { > + if (bo->tbo.type != ttm_bo_type_kernel) { > ubo = to_amdgpu_bo_user(bo); > kfree(ubo->metadata); > } _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx