[AMD Official Use Only - Internal Distribution Only] > -----Original Message----- > From: Borislav Petkov <bp@xxxxxxxxx> > Sent: Friday, May 14, 2021 3:06 AM > To: Joshi, Mukul <Mukul.Joshi@xxxxxxx> > Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Kasiviswanathan, Harish > <Harish.Kasiviswanathan@xxxxxxx>; x86-ml <x86@xxxxxxxxxx>; lkml <linux- > kernel@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH] drm/amdgpu: Register bad page handler for Aldebaran > > [CAUTION: External Email] > > On Thu, May 13, 2021 at 11:10:34PM +0000, Joshi, Mukul wrote: > > That's probably not the best example to look at. > > Oh, it is the *perfect* example but... > I would prefer not to get into an argument of if it is the perfect example or not. I would prefer to get the job done and move forward. > > smca_get_long_name() is used in drivers/edac/mce_amd.c and this file > > doesn't get compiled when CONFIG_X86_MCE_AMD is not defined. > > > > And amdgpu driver has no dependency on CONFIG_X86_MCE_AMD. > > ... maybe this will make you see it the right way: how much of the amdgpu RAS > functionality you're adding, is going to even function without > CONFIG_X86_MCE_AMD? > We have RAS functionality in other ASICs that is not dependent on CONFIG_X86_MCE_AMD. So, I don't think we would want to do that just for one ASIC. Maybe Alex D. has an opinion on it. As I had mentioned in my previous comment, I am fine with wrapping around my code with #ifdef CONFIG_X86_MCE_AMD and exporting smca_get_bank_type(). I hope we can move forward with this approach. Thanks, Mukul > -- > Regards/Gruss, > Boris. > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeople. > kernel.org%2Ftglx%2Fnotes-about- > netiquette&data=04%7C01%7CMukul.Joshi%40amd.com%7C7fded9165e6 > 64dde943808d916a6b33f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0 > %7C637565727509040995%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw > MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata > =5hNyAEla4H%2BN0kMdCDs6iL0Dr8mVQJNxKA0UXJU7%2F8c%3D&reserv > ed=0 _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
