RE: [PATCH] drm/amdgpu: Field type update in drm_amdgpu_info_vbios

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[AMD Official Use Only - Internal Distribution Only]

 

Done. UMR patch sent out.

 

Hi Tom,

 

Please help review it to bring the umr part back.

 

Thanks in advance!

Jiawei

 

From: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
Sent: Tuesday, May 11, 2021 9:16 PM
To: Gu, JiaWei (Will) <JiaWei.Gu@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: StDenis, Tom <Tom.StDenis@xxxxxxx>; keescook@xxxxxxxxxxxx; Nieto, David M <David.Nieto@xxxxxxx>
Subject: Re: [PATCH] drm/amdgpu: Field type update in drm_amdgpu_info_vbios

 

[AMD Official Use Only - Internal Distribution Only]

 

Please update the umr patch as well. 

 

Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>

 


From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of Jiawei Gu <Jiawei.Gu@xxxxxxx>
Sent: Tuesday, May 11, 2021 1:31 AM
To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>
Cc: StDenis, Tom <Tom.StDenis@xxxxxxx>; Gu, JiaWei (Will) <JiaWei.Gu@xxxxxxx>; keescook@xxxxxxxxxxxx <keescook@xxxxxxxxxxxx>; Nieto, David M <David.Nieto@xxxxxxx>
Subject: [PATCH] drm/amdgpu: Field type update in drm_amdgpu_info_vbios

 

Use numeric type serial in drm_amdgpu_info_vbios instead.

Signed-off-by: Jiawei Gu <Jiawei.Gu@xxxxxxx>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +-
 include/uapi/drm/amdgpu_drm.h           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
index 75f34a9008e7..e1008a79b441 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
@@ -871,7 +871,7 @@ int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file *filp)
                         memcpy(vbios_info.vbios_pn, atom_context->vbios_pn, sizeof(atom_context->vbios_pn));
                         vbios_info.version = atom_context->version;
                         memcpy(vbios_info.date, atom_context->date, sizeof(atom_context->date));
-                       memcpy(vbios_info.serial, adev->serial, sizeof(adev->serial));
+                       vbios_info.serial = adev->unique_id;
                         vbios_info.dev_id = adev->pdev->device;
                         vbios_info.rev_id = adev->pdev->revision;
                         vbios_info.sub_dev_id = atom_context->sub_dev_id;
diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h
index 2b487a8d2727..2d9e84658bbc 100644
--- a/include/uapi/drm/amdgpu_drm.h
+++ b/include/uapi/drm/amdgpu_drm.h
@@ -957,7 +957,7 @@ struct drm_amdgpu_info_vbios {
         __u8 vbios_pn[64];
         __u32 version;
         __u8 date[32];
-       __u8 serial[16];
+       __u64 serial;
         __u32 dev_id;
         __u32 rev_id;
         __u32 sub_dev_id;
--
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://nam11.safelinks.protection.outlook.com/?url="">

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux