Am 2021-05-03 um 1:25 p.m. schrieb Joseph Greathouse:
> Navi series GPUs have 2 SIMDs per CU (and then 2 CUs per WGP).
> The NV enum headers incorrectly listed this as 4, which later meant
> we were incorrectly reporting the number of SIMDs in the HSA
> topology. This could cause problems down the line for user-space
> applications that want to launch a fixed amount of work to each
> SIMD.
>
> Signed-off-by: Joseph Greathouse <Joseph.Greathouse@xxxxxxx>
> Change-Id: I94021ca71363a3d27330b2fda8e6acaac258017e
Please remove the Change-Id. You can disable generation of Change-Ids in
your kernel repository with this command:
git config --bool gerrit.createChangeId false
The change looks good to me. As far as I can see in the code this would
fix both the simd_count and simd_per_cu properties in the KFD topology.
I don't see this value used anywhere else in amdgpu, so there shouldn't
be any other unexpected side effects.
Reviewed-by: Felix Kuehling <Felix.Kuehling@xxxxxxx>
> ---
> drivers/gpu/drm/amd/include/navi10_enum.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/include/navi10_enum.h b/drivers/gpu/drm/amd/include/navi10_enum.h
> index d5ead9680c6e..84bcb96f76ea 100644
> --- a/drivers/gpu/drm/amd/include/navi10_enum.h
> +++ b/drivers/gpu/drm/amd/include/navi10_enum.h
> @@ -430,7 +430,7 @@ ARRAY_2D_DEPTH = 0x00000001,
> */
>
> typedef enum ENUM_NUM_SIMD_PER_CU {
> -NUM_SIMD_PER_CU = 0x00000004,
> +NUM_SIMD_PER_CU = 0x00000002,
> } ENUM_NUM_SIMD_PER_CU;
>
> /*
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
