Am 2021-04-08 um 11:02 a.m. schrieb Jason Gunthorpe: > On Mon, Apr 05, 2021 at 09:45:55PM -0400, Felix Kuehling wrote: >> Rebased on upstream. Dropped already upstream patch >> "drm/amdgpu: reserve fence slot to update page table". >> >> Added more fixes: >> - Fixed kernel test robot warnings about static functions >> - Fixed a kernel test robot warning about an unused variable >> - Fixed a kernel test robot warning about select DEVICE_PRIVATE. >> Using "depends on" now. (see patch 34) >> - Proportionally longer timeout for hmm_range_fault on large address ranges >> (see patch 6) >> - Fixed PTE flags for XGMI mappings on Arcturus and Aldebaran (see patch 17) >> - Fixed range-list cleanup on process termination to avoid BUGs from dangling >> interval notifiers (see patch 16) >> - Fixed SVM range locking and interval notifier sequence update >> (see patch 8 and related tweaks in patches 10, 11, 21) >> >> Added my Reviewed-by to all patches primarily authored by Philip and Alex. >> I believe this patch series is nearly ready to go. >> >> This series and the corresponding ROCm Thunk and KFDTest changes are also >> available on gitub and patchwork. >> >> Link: https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/tree/fxkamd/hmm-wip >> Link: https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/tree/fxkamd/hmm-wip >> Link: https://patchwork.freedesktop.org/series/85563/ >> CC: Jérôme Glisse <jglisse@xxxxxxxxxx> >> CC: Jason Gunthorpe <jgg@xxxxxxxx> > This series is huge, but it looks like it still doesn't fix the > FIXME's around the AMD driver use of hmm. > > Can you fix them before piling on more stuff? It does avoid making the same mistakes in the new code. I'll take another look at the pre-existing FIXMEs with the experience gained working on this series. Regards, Felix > > Jaason _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx