[AMD Public Use] Acked-by: Evan Quan <evan.quan@xxxxxxx> > -----Original Message----- > From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Alex > Deucher > Sent: Saturday, March 27, 2021 4:58 AM > To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx> > Subject: [PATCH] drm/amdgpu/vangogh: don't check for dpm in > is_dpm_running when in suspend > > Do the same thing we do for Renoir. We can check, but since > the sbios has started DPM, it will always return true which > causes the driver to skip some of the SMU init when it shouldn't. > > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx> > --- > drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > index 2f502fec67d5..ed11e0ab8299 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > @@ -384,10 +384,15 @@ static int vangogh_dpm_set_jpeg_enable(struct > smu_context *smu, bool enable) > > static bool vangogh_is_dpm_running(struct smu_context *smu) > { > + struct amdgpu_device *adev = smu->adev; > int ret = 0; > uint32_t feature_mask[2]; > uint64_t feature_enabled; > > + /* we need to re-init after suspend so return false */ > + if (adev->in_suspend) > + return false; > + > ret = smu_cmn_get_enabled_32_bits_mask(smu, feature_mask, 2); > > if (ret) > -- > 2.30.2 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists. > freedesktop.org%2Fmailman%2Flistinfo%2Famd- > gfx&data=04%7C01%7Cevan.quan%40amd.com%7C43d4981ccc7545675 > bfe08d8f099fac3%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637 > 523891416957673%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAi > LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=2C > 8w1ValXDpaPW3jzDN%2BdNmiDK10FOxgQ20h%2FJ%2F66sc%3D&reser > ved=0 _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx