|
[AMD Official Use Only - Internal Distribution Only] Hi All,
Thanks for the inputs, have updated the patch to include these changes.
Regards,
Bindu
From: Lakha, Bhawanpreet <Bhawanpreet.Lakha@xxxxxxx>
Sent: Wednesday, March 17, 2021 1:02 PM To: Michel Dänzer <michel@xxxxxxxxxxx>; R, Bindu <Bindu.R@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Feng, Kenneth <Kenneth.Feng@xxxxxxx>; Zhou1, Tao <Tao.Zhou1@xxxxxxx> Subject: Re: [PATCH] drm/amd/display: Allow idle optimization based on vblank.
[AMD Official Use Only - Internal Distribution Only]
Hi Bindu,
dc_allow_idle_optimizations() should be called within mutex_lock(&dm->dc_lock). Please call it right after WARN_ON(!dc_commit_state(dm->dc, dc_state)) but before unlock().
Bhawan
From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of Michel Dänzer <michel@xxxxxxxxxxx>
Sent: March 17, 2021 7:37 AM To: R, Bindu <Bindu.R@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Feng, Kenneth <Kenneth.Feng@xxxxxxx>; Zhou1, Tao <Tao.Zhou1@xxxxxxx>; Lakha, Bhawanpreet <Bhawanpreet.Lakha@xxxxxxx> Subject: Re: [PATCH] drm/amd/display: Allow idle optimization based on vblank. On 2021-03-17 12:49 a.m., Bindu Ramamurthy wrote:
> [Why] > idle optimization was being disabled after commit. > > [How] > check vblank count for display off and enable idle optimization based on this count. > > Signed-off-by: Bindu Ramamurthy <bindu.r@xxxxxxx> > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > index 553e39f9538c..56a55143ad2d 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -987,7 +987,7 @@ static void event_mall_stutter(struct work_struct *work) > > if (vblank_work->enable) > dm->active_vblank_irq_count++; > - else > + else if(dm->active_vblank_irq_count) > dm->active_vblank_irq_count--; The commit log should explain why this part is needed. -- Earthling Michel Dänzer | https://nam11.safelinks.protection.outlook.com/?url=""> Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://nam11.safelinks.protection.outlook.com/?url=""> |
_______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
