On Mon, Mar 8, 2021 at 3:20 PM Christian König <christian.koenig@xxxxxxx> wrote:
>
> Am 08.03.21 um 16:37 schrieb Nirmoy Das:
> > FB BO should not be ttm_bo_type_kernel type and
> > amdgpufb_create_pinned_object() pins the FB BO anyway.
>
> Mhm, why the heck was that a kernel object?
Maybe because the fbcon was the main user for this historically and
the code was copied from radeon which also still sets it to kernel.
Alex
>
> >
> > Signed-off-by: Nirmoy Das <nirmoy.das@xxxxxxx>
>
> Acked-by: Christian König <christian.koenig@xxxxxxx>
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> > index 51cd49c6f38f..24010cacf7d0 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> > @@ -146,7 +146,7 @@ static int amdgpufb_create_pinned_object(struct amdgpu_fbdev *rfbdev,
> > size = mode_cmd->pitches[0] * height;
> > aligned_size = ALIGN(size, PAGE_SIZE);
> > ret = amdgpu_gem_object_create(adev, aligned_size, 0, domain, flags,
> > - ttm_bo_type_kernel, NULL, &gobj);
> > + ttm_bo_type_device, NULL, &gobj);
> > if (ret) {
> > pr_err("failed to allocate framebuffer (%d)\n", aligned_size);
> > return -ENOMEM;
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
