RE: [PATCH] drm/amdgpu: Check if FB BAR is enabled for ROM read

["Zhang, Hawking" <Hawking.Zhang@xxxxxxx>]

[AMD Public Use]

 

Reviewed-by: Hawking Zhang <Hawking.Zhang@xxxxxxx>

 

Regards,
Hawking

From: Lazar, Lijo <Lijo.Lazar@xxxxxxx>
Sent: Monday, March 8, 2021 21:16
To: Lazar, Lijo <Lijo.Lazar@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Xu, Feifei <Feifei.Xu@xxxxxxx>; Zhang, Hawking <Hawking.Zhang@xxxxxxx>
Subject: RE: [PATCH] drm/amdgpu: Check if FB BAR is enabled for ROM read

 

[AMD Public Use]

 

<Ping>

 

From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Lazar, Lijo
Sent: Wednesday, March 3, 2021 10:15 AM
To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Xu, Feifei <Feifei.Xu@xxxxxxx>; Zhang, Hawking <Hawking.Zhang@xxxxxxx>
Subject: [PATCH] drm/amdgpu: Check if FB BAR is enabled for ROM read

 

[AMD Public Use]

 

Some configurations don't have FB BAR enabled. Avoid reading ROM image

from FB BAR region in such cases.

 

Signed-off-by: Lijo Lazar <lijo.lazar@xxxxxxx>

Reviewed-by: Hawking Zhang <Hawking.Zhang@xxxxxxx>

Reviewed-by: Feifei Xu <Feifei.Xu@xxxxxxx>

---

drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 4 ++++

1 file changed, 4 insertions(+)

 

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c

index efdf639f6593..f454a6bd0ed6 100644

--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c

+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c

@@ -97,6 +97,10 @@ static bool igp_read_bios_from_vram(struct amdgpu_device *adev)

                if (amdgpu_device_need_post(adev))

                        return false;

 

+       /* FB BAR not enabled */

+       if (pci_resource_len(adev->pdev, 0) == 0)

+               return false;

+

        adev->bios = NULL;

        vram_base = pci_resource_start(adev->pdev, 0);

        bios = ioremap_wc(vram_base, size);

--

2.29.2

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx