This builds on the debugging and patches that Takashi did on the bugs referenced in the patches. It seems some latops claim to support aux backlight control, but actually use the old pwm controller. The code also currently warns in the backlight control function if there is no pipe assigned, but this is a common case if the display happens to be off when the backlight level is changed and it just spams the logs, so remove it. This set wires up the aux controller to the backlight control, cleans up the code an bit, removes the assert, and adds an option to override the backlight type. @Display team, can you check if there are any quirks or differences in the backlight control detection on windows? Presumably this is properly detected there. The systems in question claim to support aux backlight control in their DPCDs, but that doesn't seem to work. Alex Deucher (3): drm/amdgpu/display: simplify backlight setting drm/amdgpu/display: don't assert in set backlight function drm/amdgpu/display: handle aux backlight in backlight_get_brightness Takashi Iwai (1): drm/amd/display: Add a backlight module option drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++ .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 49 +++++++++++-------- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 1 - 4 files changed, 34 insertions(+), 21 deletions(-) -- 2.29.2 _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
