Re: [PATCH] drm/amdgpu: correct TA RAP firmware information print error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[AMD Public Use]


yes, I have the same idea and agree with you.

but patch is merged, I will add a new patch to refine it.

Best Regards,
Kevin

From: Zhang, Hawking <Hawking.Zhang@xxxxxxx>
Sent: Monday, March 1, 2021 1:23 PM
To: Wang, Kevin(Yang) <Kevin1.Wang@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>
Cc: Li, Candice <Candice.Li@xxxxxxx>; Wang, Kevin(Yang) <Kevin1.Wang@xxxxxxx>
Subject: RE: [PATCH] drm/amdgpu: correct TA RAP firmware information print error
 
[AMD Public Use]

Instead of hard code the number of TA, it would be better to leverage enum ta_fw_type definition, explicitly call out TA_TYPE for each case in both amdgpu_firmware_info and amdgpu_debugfs_firmware_info_show.

Regards,
Hawking
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Kevin Wang
Sent: Monday, March 1, 2021 10:52
To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Li, Candice <Candice.Li@xxxxxxx>; Wang, Kevin(Yang) <Kevin1.Wang@xxxxxxx>
Subject: [PATCH] drm/amdgpu: correct TA RAP firmware information print error

miss RAP TA in loop ( when i == 4)

Fix:
drm/amdgpu: add RAP TA version print in amdgpu_firmware_info

Signed-off-by: Kevin Wang <kevin1.wang@xxxxxxx>
Reported-by: Candice Li <candice.li@xxxxxxx>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
index a5ed9530f542..6c8ea9d26320 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
@@ -1472,7 +1472,7 @@ static int amdgpu_debugfs_firmware_info_show(struct seq_file *m, void *unused)
                    fw_info.feature, fw_info.ver);
 
         query_fw.fw_type = AMDGPU_INFO_FW_TA;
-       for (i = 0; i < 4; i++) {
+       for (i = 0; i < 5; i++) {
                 query_fw.index = i;
                 ret = amdgpu_firmware_info(&fw_info, &query_fw, adev);
                 if (ret)
--
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://nam11.safelinks.protection.outlook.com/?url="">
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux