Re: [PATCH] drm/amdgpu/pm: make unsupported power profile messages debug

[Nirmoy <nirmodas@xxxxxxx>]

Acked-by: Nirmoy Das <nirmoy.das@xxxxxxx>

On 2/24/21 6:28 PM, Alex Deucher wrote:
> Making them an error confuses users and the errors are harmless
> as not all asics support all profiles.
>
> Bug: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fdrm%2Famd%2F-%2Fissues%2F1488&amp;data=04%7C01%7Cnirmoy.das%40amd.com%7C4e46d63ffe1d4cdbda6608d8d8e9b2e6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637497845534449026%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=%2FRCM%2FzZyJtkIpdRDsN0UUxZIT1Sqd6HwSbman36vveQ%3D&amp;reserved=0
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> ---
>   drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 2 +-
>   drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c  | 2 +-
>   drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c   | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
> index 45564a776e9b..9f0d03ae3109 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
> @@ -1322,7 +1322,7 @@ static int arcturus_set_power_profile_mode(struct smu_context *smu,
>   						       CMN2ASIC_MAPPING_WORKLOAD,
>   						       profile_mode);
>   	if (workload_type < 0) {
> -		dev_err(smu->adev->dev, "Unsupported power profile mode %d on arcturus\n", profile_mode);
> +		dev_dbg(smu->adev->dev, "Unsupported power profile mode %d on arcturus\n", profile_mode);
>   		return -EINVAL;
>   	}
>   
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> index 7b7ae5532ddb..fd5539f8b53a 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> @@ -810,7 +810,7 @@ static int vangogh_set_power_profile_mode(struct smu_context *smu, long *input,
>   						       CMN2ASIC_MAPPING_WORKLOAD,
>   						       profile_mode);
>   	if (workload_type < 0) {
> -		dev_err_once(smu->adev->dev, "Unsupported power profile mode %d on VANGOGH\n",
> +		dev_dbg(smu->adev->dev, "Unsupported power profile mode %d on VANGOGH\n",
>   					profile_mode);
>   		return -EINVAL;
>   	}
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c
> index 9a8b1a1e148e..c9f766cbe227 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c
> @@ -826,7 +826,7 @@ static int renoir_set_power_profile_mode(struct smu_context *smu, long *input, u
>   		 * TODO: If some case need switch to powersave/default power mode
>   		 * then can consider enter WORKLOAD_COMPUTE/WORKLOAD_CUSTOM for power saving.
>   		 */
> -		dev_err_once(smu->adev->dev, "Unsupported power profile mode %d on RENOIR\n", profile_mode);
> +		dev_dbg(smu->adev->dev, "Unsupported power profile mode %d on RENOIR\n", profile_mode);
>   		return -EINVAL;
>   	}
>   
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx