Re: [PATCH] drm/amdgpu: decline max_me for mec2_fw remove in renoir/arcturus

[Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx>]

On 02/24, changfeng.zhu@xxxxxxx wrote:
> From: changzhu <Changfeng.Zhu@xxxxxxx>
> 
> From: Changfeng <Changfeng.Zhu@xxxxxxx>
> 
> The value of max_me in amdgpu_gfx_rlc_setup_cp_table should reduce to 4
> when mec2_fw is removed on asic renoir/arcturus. Or it will cause kernel
> NULL pointer when modprobe driver.

Hi,

The commit

 6972f8d17f3603a6b002e42f7890a42d77e3e50b
 drm/amdgpu: disable mec2 fw bin loading

introduced a regression to Renoir systems, basically the system hangs
and your patch fixed the issue. I recommend you to add the Fixes label,
i.e.:

Fixes: 6972f8d17f36 ("drm/amdgpu: disable mec2 fw bin loading")

With that change,

Tested-by: Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx>
 
> Change-Id: I268610e85f6acd9200478d0ab1518349ff81469b

Also, do we need this Change-Id?

Best Regards
Siqueira

> Signed-off-by: Changfeng <Changfeng.Zhu@xxxxxxx>
> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> index 2f56adebbb31..300a07227597 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> @@ -1890,7 +1890,10 @@ static void gfx_v9_0_enable_lbpw(struct amdgpu_device *adev, bool enable)
>  
>  static int gfx_v9_0_cp_jump_table_num(struct amdgpu_device *adev)
>  {
> -	return 5;
> +	if (gfx_v9_0_load_mec2_fw_bin_support(adev))
> +		return 5;
> +	else
> +		return 4;
>  }
>  
>  static int gfx_v9_0_rlc_init(struct amdgpu_device *adev)
> -- 
> 2.17.1
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=04%7C01%7CRodrigo.Siqueira%40amd.com%7Cccb7b58ed1df4111bc6b08d8d8a42b59%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637497546910967958%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=z0S60q8SZYqI3sHYZRucI2FjuXqll9ZdLfreHl8AQyo%3D&amp;reserved=0

-- 
Rodrigo Siqueira
https://siqueira.tech

Attachment: signature.asc
Description: PGP signature

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx