We don't want a semi-transparent overlay to make the cursor plane semi-transparent as well. Same for the pixel blend mode. Signed-off-by: Simon Ser <contact@xxxxxxxxxxx> Cc: Alex Deucher <alexander.deucher@xxxxxxx> Cc: Harry Wentland <hwentlan@xxxxxxx> Cc: Nicholas Kazlauskas <nicholas.kazlauskas@xxxxxxx> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 6e7f4a182e89..d6ecc5826be9 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -9257,6 +9257,16 @@ static int dm_check_crtc_cursor(struct drm_atomic_state *state, return -EINVAL; } + if (new_underlying_state->alpha != DRM_BLEND_ALPHA_OPAQUE) { + drm_dbg_atomic(crtc->dev, "Cursor plane can't be used with non-opaque underlying plane\n"); + return -EINVAL; + } + + if (new_underlying_state->pixel_blend_mode != DRM_MODE_BLEND_PREMULTI) { + drm_dbg_atomic(crtc->dev, "Cursor plane can't be used with non-premultiplied underlying plane\n"); + return -EINVAL; + } + return 0; } -- 2.30.1 _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx