On Friday, February 19th, 2021 at 6:41 PM, Kazlauskas, Nicholas <nicholas.kazlauskas@xxxxxxx> wrote: > > Related: how does this affect scaling? Right now there is a check that makes > > sure the cursor plane scaling matches the primary plane's. Should we instead > > check that the cursor plane scaling matches the top-most XRGB/ARGB plane's? > > > > Can't really do scaling on the cursor plane itself. It scales with the > underlying pipe driving it so it'll only be correct if it matches that. > > Primary plane isn't the correct check here since we always use the > topmost pipe in the blending chain to draw the cursor - in the example I > gave it'd have to match the overlay plane's scaling, not the primary > plane's. OK, thanks for the info. That means the check I introduced some time ago is wrong (it's right above my patch). I'll send a fix for that too. _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
