Hi Jiawei,
ok in this case it's fine with me.
Just please also get a reviewed-by from somebody which has more KIQ
background than I have.
Thanks,
Christian.
Am 08.02.21 um 11:00 schrieb Gu, JiaWei (Will):
[AMD Official Use Only - Internal Distribution Only]
Hi Christian,
That's how many times it would retry before give up.
And we always skip this retry routine if we are in interrupt, so it's fine for interrupt condition.
Best regards,
Jiawei
-----Original Message-----
From: Christian König <ckoenig.leichtzumerken@xxxxxxxxx>
Sent: Monday, February 8, 2021 5:28 PM
To: Gu, JiaWei (Will) <JiaWei.Gu@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Deng, Emily <Emily.Deng@xxxxxxx>
Subject: Re: [PATCH] drm/amdgpu: extend MAX_KIQ_REG_TRY to 1000
Am 08.02.21 um 06:45 schrieb Jiawei Gu:
Extend retry times of KIQ to avoid starvation situation caused by long
time full access of GPU by other VFs.
In what units is that? We also need the KIQ during interrupt handling and that looks like *way* to big for that.
Christian.
Signed-off-by: Jiawei Gu <Jiawei.Gu@xxxxxxx>
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index 639db32c1383..e0c797a5f739 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
@@ -288,7 +288,7 @@ enum amdgpu_kiq_irq {
#define MAX_KIQ_REG_WAIT 5000 /* in usecs, 5ms */
#define MAX_KIQ_REG_BAILOUT_INTERVAL 5 /* in msecs, 5ms */
-#define MAX_KIQ_REG_TRY 80 /* 20 -> 80 */
+#define MAX_KIQ_REG_TRY 1000
int amdgpu_device_ip_set_clockgating_state(void *dev,
enum amd_ip_block_type block_type,
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
