[AMD Public Use]
Indeed it will. Consider this dropped, as no one was asking for it anyways.
Kent
> -----Original Message-----
> From: Kuehling, Felix <Felix.Kuehling@xxxxxxx>
> Sent: Wednesday, February 3, 2021 1:38 PM
> To: Russell, Kent <Kent.Russell@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH] drm/amdkfd: Print unique_id as hex instead of decimal
>
> Doesn't this break the ABI?
>
> Am 2021-02-03 um 1:22 p.m. schrieb Kent Russell:
> > Add a new helper function for printing Topology values to support
> > printing 64-bit hex values. Use this for unique_id to ensure that the
> > unique_id in KFD's topology matches the one in amdgpu's sysfs pool.
> >
> > Signed-off-by: Kent Russell <kent.russell@xxxxxxx>
> > ---
> > drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> > index a3fc23873819..4e4f651dcb88 100644
> > --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> > @@ -217,6 +217,8 @@ struct kfd_topology_device *kfd_create_topology_device(
> > sysfs_show_gen_prop(buffer, offs, "%s %u\n", name, value)
> > #define sysfs_show_64bit_prop(buffer, offs, name, value) \
> > sysfs_show_gen_prop(buffer, offs, "%s %llu\n", name, value)
> > +#define sysfs_show_64bit_hex_prop(buffer, offs, name, value) \
> > + sysfs_show_gen_prop(buffer, offs, "%s %llx\n", name, value)
> > #define sysfs_show_32bit_val(buffer, offs, value) \
> > sysfs_show_gen_prop(buffer, offs, "%u\n", value)
> > #define sysfs_show_str_val(buffer, offs, value) \
> > @@ -497,7 +499,7 @@ static ssize_t node_show(struct kobject *kobj, struct attribute
> *attr,
> > dev->node_props.num_sdma_queues_per_engine);
> > sysfs_show_32bit_prop(buffer, offs, "num_cp_queues",
> > dev->node_props.num_cp_queues);
> > - sysfs_show_64bit_prop(buffer, offs, "unique_id",
> > + sysfs_show_64bit_hex_prop(buffer, offs, "unique_id",
> > dev->node_props.unique_id);
> >
> > if (dev->gpu) {
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
