Re: [PATCH 1/1] drm/amdgpu: enable wave limit on non high prio cs pipes

Nirmoy <nirmodas@xxxxxxx> · Wed, 3 Feb 2021 18:05:21 +0100

On 2/3/21 5:56 PM, Alex Deucher wrote:
On Wed, Feb 3, 2021 at 11:07 AM Nirmoy Das <nirmoy.das@xxxxxxx> wrote:
To achieve the best QoS for high priority compute jobs it is
required to limit waves on other compute pipes as well.
This patch will set min value in non high priority
mmSPI_WCL_PIPE_PERCENT_CS[0-3] registers to minimize the
impact of normal/low priority compute jobs over high priority
compute jobs.

Signed-off-by: Nirmoy Das <nirmoy.das@xxxxxxx>
---
  drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 49 ++++++++++++++++++++++++++-
  drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 46 ++++++++++++++++++++++++-
  2 files changed, 93 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index bdfd29a22b3d..28dbce1083ab 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
@@ -6846,10 +6846,44 @@ static void gfx_v8_0_emit_mem_sync_compute(struct amdgpu_ring *ring)
         amdgpu_ring_write(ring, 0x0000000A);    /* poll interval */
  }

+
+/* mmSPI_WCL_PIPE_PERCENT_CS[0-7]_DEFAULT values are same */
+#define mmSPI_WCL_PIPE_PERCENT_CS_DEFAULT      0x0000007f
+static void gfx_v8_0_emit_wave_limit_cs(struct amdgpu_ring *ring,
+                                       uint32_t pipe, bool enable)
+{
+       uint32_t val;
+       uint32_t wcl_cs_reg;
+
+       val = enable ? 0x1 : mmSPI_WCL_PIPE_PERCENT_CS_DEFAULT;
+
+       switch (pipe) {
+       case 0:
+               wcl_cs_reg = mmSPI_WCL_PIPE_PERCENT_CS0;
+               break;
+       case 1:
+               wcl_cs_reg = mmSPI_WCL_PIPE_PERCENT_CS1;
+               break;
+       case 2:
+               wcl_cs_reg = mmSPI_WCL_PIPE_PERCENT_CS2;
+               break;
+       case 3:
+               wcl_cs_reg = mmSPI_WCL_PIPE_PERCENT_CS3;
+               break;
+       default:
+               DRM_DEBUG("invalid pipe %d\n", pipe);
+               return;
+       }
+
+       amdgpu_ring_emit_wreg(ring, wcl_cs_reg, val);
+
+}
+
  #define mmSPI_WCL_PIPE_PERCENT_GFX_DEFAULT     0x07ffffff
  static void gfx_v8_0_emit_wave_limit(struct amdgpu_ring *ring, bool enable)
  {
         uint32_t val;
+       int i;

         /* mmSPI_WCL_PIPE_PERCENT_GFX is 7 bit multiplier register to limit
          * number of gfx waves. Setting 5 bit will make sure gfx only gets
@@ -6857,6 +6891,18 @@ static void gfx_v8_0_emit_wave_limit(struct amdgpu_ring *ring, bool enable)
          */
         val = enable ? 0x1f : mmSPI_WCL_PIPE_PERCENT_GFX_DEFAULT;
         amdgpu_ring_emit_wreg(ring, mmSPI_WCL_PIPE_PERCENT_GFX, val);
+
+       /* Restrict waves for normal/low priority compute queues as well
+        * to get best QoS for high priority compute jobs.
+        *
+        * amdgpu controls only 1st ME(0-3 CS pipes).
+        */
+       for (i = 0; i < 4; i++) {
How about using adev->gfx.mec.num_pipe_per_mec instead of hardcoding 4 here?


Thanks Alex, let me resend with that change.


Nirmoy



+               if (i != ring->pipe)
+                       gfx_v8_0_emit_wave_limit_cs(ring, i, enable);
+
+       }
+
  }

  static const struct amd_ip_funcs gfx_v8_0_ip_funcs = {
@@ -6943,7 +6989,8 @@ static const struct amdgpu_ring_funcs gfx_v8_0_ring_funcs_compute = {
                 VI_FLUSH_GPU_TLB_NUM_WREG * 5 + 7 + /* gfx_v8_0_ring_emit_vm_flush */
                 7 + 7 + 7 + /* gfx_v8_0_ring_emit_fence_compute x3 for user fence, vm fence */
                 7 + /* gfx_v8_0_emit_mem_sync_compute */
-               5, /* gfx_v8_0_emit_wave_limit for updating mmSPI_WCL_PIPE_PERCENT_GFX register */
+               5 + /* gfx_v8_0_emit_wave_limit for updating mmSPI_WCL_PIPE_PERCENT_GFX register */
+               15, /* for updating 3 mmSPI_WCL_PIPE_PERCENT_CS registers */
         .emit_ib_size = 7, /* gfx_v8_0_ring_emit_ib_compute */
         .emit_ib = gfx_v8_0_ring_emit_ib_compute,
         .emit_fence = gfx_v8_0_ring_emit_fence_compute,
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 027997e95e46..e44487ae15dc 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
@@ -6668,10 +6668,42 @@ static void gfx_v9_0_emit_mem_sync(struct amdgpu_ring *ring)
         amdgpu_ring_write(ring, 0x0000000A); /* POLL_INTERVAL */
  }

+static void gfx_v9_0_emit_wave_limit_cs(struct amdgpu_ring *ring,
+                                       uint32_t pipe, bool enable)
+{
+       struct amdgpu_device *adev = ring->adev;
+       uint32_t val;
+       uint32_t wcl_cs_reg;
+
+       /* mmSPI_WCL_PIPE_PERCENT_CS[0-7]_DEFAULT values are same */
+       val = enable ? 0x1 : mmSPI_WCL_PIPE_PERCENT_CS0_DEFAULT;
+
+       switch (pipe) {
+       case 0:
+               wcl_cs_reg = SOC15_REG_OFFSET(GC, 0, mmSPI_WCL_PIPE_PERCENT_CS0);
+               break;
+       case 1:
+               wcl_cs_reg = SOC15_REG_OFFSET(GC, 0, mmSPI_WCL_PIPE_PERCENT_CS1);
+               break;
+       case 2:
+               wcl_cs_reg = SOC15_REG_OFFSET(GC, 0, mmSPI_WCL_PIPE_PERCENT_CS2);
+               break;
+       case 3:
+               wcl_cs_reg = SOC15_REG_OFFSET(GC, 0, mmSPI_WCL_PIPE_PERCENT_CS3);
+               break;
+       default:
+               DRM_DEBUG("invalid pipe %d\n", pipe);
+               return;
+       }
+
+       amdgpu_ring_emit_wreg(ring, wcl_cs_reg, val);
+
+}
  static void gfx_v9_0_emit_wave_limit(struct amdgpu_ring *ring, bool enable)
  {
         struct amdgpu_device *adev = ring->adev;
         uint32_t val;
+       int i;


         /* mmSPI_WCL_PIPE_PERCENT_GFX is 7 bit multiplier register to limit
@@ -6682,6 +6714,17 @@ static void gfx_v9_0_emit_wave_limit(struct amdgpu_ring *ring, bool enable)
         amdgpu_ring_emit_wreg(ring,
                               SOC15_REG_OFFSET(GC, 0, mmSPI_WCL_PIPE_PERCENT_GFX),
                               val);
+
+       /* Restrict waves for normal/low priority compute queues as well
+        * to get best QoS for high priority compute jobs.
+        *
+        * amdgpu controls only 1st ME(0-3 CS pipes).
+        */
+       for (i = 0; i < 4; i++) {
Same comment here.

+               if (i != ring->pipe)
+                       gfx_v9_0_emit_wave_limit_cs(ring, i, enable);
+
+       }
  }

  static const struct amd_ip_funcs gfx_v9_0_ip_funcs = {
@@ -6774,7 +6817,8 @@ static const struct amdgpu_ring_funcs gfx_v9_0_ring_funcs_compute = {
                 2 + /* gfx_v9_0_ring_emit_vm_flush */
                 8 + 8 + 8 + /* gfx_v9_0_ring_emit_fence x3 for user fence, vm fence */
                 7 + /* gfx_v9_0_emit_mem_sync */
-               5, /* gfx_v9_0_emit_wave_limit for updating mmSPI_WCL_PIPE_PERCENT_GFX register */
+               5 + /* gfx_v9_0_emit_wave_limit for updating mmSPI_WCL_PIPE_PERCENT_GFX register */
+               15, /* for updating 3 mmSPI_WCL_PIPE_PERCENT_CS registers */
         .emit_ib_size = 7, /* gfx_v9_0_ring_emit_ib_compute */
         .emit_ib = gfx_v9_0_ring_emit_ib_compute,
         .emit_fence = gfx_v9_0_ring_emit_fence,
--
2.30.0

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=04%7C01%7Cnirmoy.das%40amd.com%7C94ee191a465b4aa441d008d8c864bde7%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637479682338092636%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=g8wQEFZDuLBfYH8nzrKh6tPgbUqvnyHjM%2BrJHqvbybA%3D&amp;reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx






