Am 2021-01-18 um 2:53 a.m. schrieb Christian König: > Am 15.01.21 um 19:24 schrieb Felix Kuehling: >> ROCm user mode depends on userptr support. Without it, KFD is basically >> useless. >> >> Signed-off-by: Felix Kuehling <Felix.Kuehling@xxxxxxx> >> --- >> drivers/gpu/drm/amd/amdkfd/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig >> b/drivers/gpu/drm/amd/amdkfd/Kconfig >> index e8fb10c41f16..2800b2bb2522 100644 >> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig >> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig >> @@ -8,5 +8,6 @@ config HSA_AMD >> depends on DRM_AMDGPU && (X86_64 || ARM64 || PPC64) >> imply AMD_IOMMU_V2 if X86_64 >> select MMU_NOTIFIER >> + select DRM_AMDGPU_USERPTR > > I think we should rather make that a depends on. Otherwise we select a > visible config option. I was considering that. The problem with that is, that the HSA_AMD option won't even show up in menuconfig unless DRM_AMDGPU_USERPTR is selected. I'd rather always show the HSA_AMD option and select what it needs. Is there a good reason why AMDGPU_USERPTR is a "visible" config option? What would be a reason for a user to deliberately disable this? Regards, Felix > > Christian. > >> help >> Enable this if you want to use HSA features on AMD GPU devices. > _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
