Dear Jinzhou,
Am 14.01.21 um 08:29 schrieb Su, Jinzhou (Joe):
Thanks so much for your review. Answer your Question inline. Please check.
An email client, following standards when responding and citing messages
correctly, would be nice.
-----Original Message-----
From: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
Sent: Thursday, January 14, 2021 3:06 AM
Am 13.01.21 um 04:43 schrieb Jinzhou Su:
Add file ta_secureDisplay_if.h for Secure Display TA
What is *Secure Display TA*? Please give some background, and even examples how it can be used.
How is the header file generated?
Joe: Actually I got this from Display Team. Driver team's
responsibility is to load the TA and add interface. 😊
Then please mention that in the commit message.
What do the comments mean, when they refer to “for validation only” or similar.
Signed-off-by: Jinzhou Su <Jinzhou.Su@xxxxxxx>
Reviewed-by: Huang Rui <ray.huang@xxxxxxx>
Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>
---
.../gpu/drm/amd/amdgpu/ta_secureDisplay_if.h | 154 ++++++++++++++++++
1 file changed, 154 insertions(+)
create mode 100644 drivers/gpu/drm/amd/amdgpu/ta_secureDisplay_if.h
diff --git a/drivers/gpu/drm/amd/amdgpu/ta_secureDisplay_if.h
b/drivers/gpu/drm/amd/amdgpu/ta_secureDisplay_if.h
new file mode 100644
index 000000000000..5039375bb1d4
--- /dev/null
+++ b/drivers/gpu/drm/amd/amdgpu/ta_secureDisplay_if.h
Why is the header added in a separate commit, and not both commits squashed?
Joe: Header file need to do IP review.
Sorry, I do not understand the answer. But leave it a separate commit to
adhere to your internal processes – it’s not that important.
@@ -0,0 +1,154 @@
+/*
+ * Copyright 2019 Advanced Micro Devices, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person
+obtaining a
+ * copy of this software and associated documentation files (the
+"Software"),
+ * to deal in the Software without restriction, including without
+limitation
+ * the rights to use, copy, modify, merge, publish, distribute,
+sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom
+the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
+SHALL
+ * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM,
+DAMAGES OR
+ * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+OTHERWISE,
+ * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
+OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ *
+ */
Why not use SPDX headers?
Joe: sorry, I don't know.
Please find out? ;-)
[…]
Kind regards,
Paul
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
