On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote: > Am 07.01.21 um 19:07 schrieb Daniel Vetter: > > On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote: > > > Drivers are not supposed to init the page pool directly any more. > > > > > > Signed-off-by: Christian König <christian.koenig@xxxxxxx> > > Please include reported-by credits and link to the bug reports on > > lore.kernel.org when merging this. Also I guess this should have a Fixes: > > line? > > I'm not aware of a bug report, but the reported-by/Fixes lines are indeed > missing. This one here: https://lore.kernel.org/dri-devel/20201231104020.GA4504@xxxxxxx/ Or did I get confused, and the above is yet another bug? > BTW: Any idea why dim add-link doesn't work? Hm we occasionally have fun with email parsing (it's hard) and especially python changes in how encodings are handled differently between python2 and python3. If you have a specific example I can try and take a look why it doesn't work. -Daniel > > And maybe some words on how/why stuff blows up. > > Just a typo. I've forgot to remove two lines in radeon while rebasing and > still had the symbols exported so never noticed this. > > Christian. > > > -Daniel > > > > > --- > > > drivers/gpu/drm/radeon/radeon_ttm.c | 3 --- > > > 1 file changed, 3 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c > > > index d4328ff57757..35b715f82ed8 100644 > > > --- a/drivers/gpu/drm/radeon/radeon_ttm.c > > > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c > > > @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev) > > > } > > > rdev->mman.initialized = true; > > > - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb, > > > - dma_addressing_limited(&rdev->pdev->dev)); > > > - > > > r = radeon_ttm_init_vram(rdev); > > > if (r) { > > > DRM_ERROR("Failed initializing VRAM heap.\n"); > > > -- > > > 2.25.1 > > > > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel@xxxxxxxxxxxxxxxxxxxxx > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
