On Wed, Jan 6, 2021 at 11:25 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi All, > > I get Cc-ed on all Fedora kernel bugs and this one stood out to me: > > https://bugzilla.redhat.com/show_bug.cgi?id=1911763 > > Since I've done a lot of work on the acpi-video code I thought I should > take a look. I've managed to help the user with a kernel-commandline > option which stops video.ko (the acpi-video kernel module) from emitting > key-press events for ACPI_VIDEO_NOTIFY_PROBE events. > > This is on a Dell Vostro laptop with i915/radeon hybrid gfx. > > I was thinking about adding a DMI quirk for this, but from the brief time > that I worked on nouveau (and specifically hybrid gfx setups) I know that > these events get fired on hybrid gfx setups when the discrete GPU is > powered down and something happens which requires the discrete GPUs drivers > attention, like an external monitor being plugged into a connector handled > by the dGPU (note that is not the case here). > > So I took a quick look at the radeon code and the radeon_atif_handler() > function from drivers/gpu/drm/radeon/radeon_acpi.c. When successful that > returns NOTIFY_BAD which suppresses the key-press. > > But in various cases it returns NOTIFY_DONE instead which does not > suppress the key-press event. So I think that the spurious key-press events > which the user is seeing should be avoided by this function returning > NOTIFY_BAD. > > Specifically I'm wondering if we should not return > NOTIFY_BAD when count == 0? I guess this can cause problems if there > are multiple GPUs, but we could check if the acpi-event is for the > pci-device the radeon driver is bound to. This would require changing the > acpi-notify code to also pass the acpi_device pointer as part of the > acpi_bus_event but that should not be a problem. > For A+A PX/HG systems, we'd want the notifications for both the dGPU and the APU since some of the events are relevant to one or the other. ATIF_DGPU_DISPLAY_EVENT is only relevant to the dGPU, while ATIF_PANEL_BRIGHTNESS_CHANGE_REQUEST would be possibly relevant to both (if there was a mux), but mainly the APU. ATIF_SYSTEM_POWER_SOURCE_CHANGE_REQUEST would be relevant to both. The other events have extended bits to determine which GPU the event is targeted at. Alex > Anyways I'm hoping you all have some ideas. If necessary I can build > a Fedora test-kernel with some patches for the reporter to test. > > Regards, > > Hans > > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
