https://lists.freedesktop.org/archives/dri-devel/2021-January/292761.html is my alternative patch. On Tue, Dec 22, 2020 at 4:18 AM Zhan Liu <zhan.liu@xxxxxxx> wrote: > > [Why] > Driver cannot change amdgpu framebuffer (afb) format while doing > page flip. Force system doing so will cause ioctl error, and result in > breaking several functionalities including FreeSync. > > If afb format is forced to change during page flip, following message > will appear in dmesg.log: > > "[drm:drm_mode_page_flip_ioctl [drm]] > Page flip is not allowed to change frame buffer format." > > [How] > Do not change afb format while doing page flip. It is okay to check > whether afb format is valid here, however, forcing afb format change > shouldn't happen here. > > Signed-off-by: Zhan Liu <zhan.liu@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c > index a638709e9c92..0efebd592b65 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c > @@ -831,8 +831,6 @@ static int convert_tiling_flags_to_modifier(struct amdgpu_framebuffer *afb) > modifier); > if (!format_info) > return -EINVAL; > - > - afb->base.format = format_info; > } > } > > -- > 2.25.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
