Am 2020-12-16 um 5:34 p.m. schrieb Harish Kasiviswanathan:
> Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@xxxxxxx>
> Change-Id: Ic139a8b9c8bef1df183804e543103be206405dca
Please add a patch description (what type of problem does this fix) and
remove the "Change-Id". To stop git from adding one automatically in the
commit-msg hook, I think this should do the trick:
git config gerrit.createChangeId false
For VanGogh I don't think we need PCIe atomics. That's an APU, so system
memory access doesn't actually go through PCIe.
With that fixed, the patch is
Reviewed-by: Felix Kuehling <Felix.Kuehling@xxxxxxx>
Thanks,
Felix
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_device.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> index 50922ff2927b..0e1838637c54 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> @@ -422,7 +422,7 @@ static const struct kfd_device_info navi10_device_info = {
> .mqd_size_aligned = MQD_SIZE_ALIGNED,
> .needs_iommu_device = false,
> .supports_cwsr = true,
> - .needs_pci_atomics = false,
> + .needs_pci_atomics = true,
> .num_sdma_engines = 2,
> .num_xgmi_sdma_engines = 0,
> .num_sdma_queues_per_engine = 8,
> @@ -440,7 +440,7 @@ static const struct kfd_device_info navi12_device_info = {
> .mqd_size_aligned = MQD_SIZE_ALIGNED,
> .needs_iommu_device = false,
> .supports_cwsr = true,
> - .needs_pci_atomics = false,
> + .needs_pci_atomics = true,
> .num_sdma_engines = 2,
> .num_xgmi_sdma_engines = 0,
> .num_sdma_queues_per_engine = 8,
> @@ -458,7 +458,7 @@ static const struct kfd_device_info navi14_device_info = {
> .mqd_size_aligned = MQD_SIZE_ALIGNED,
> .needs_iommu_device = false,
> .supports_cwsr = true,
> - .needs_pci_atomics = false,
> + .needs_pci_atomics = true,
> .num_sdma_engines = 2,
> .num_xgmi_sdma_engines = 0,
> .num_sdma_queues_per_engine = 8,
> @@ -476,7 +476,7 @@ static const struct kfd_device_info sienna_cichlid_device_info = {
> .mqd_size_aligned = MQD_SIZE_ALIGNED,
> .needs_iommu_device = false,
> .supports_cwsr = true,
> - .needs_pci_atomics = false,
> + .needs_pci_atomics = true,
> .num_sdma_engines = 4,
> .num_xgmi_sdma_engines = 0,
> .num_sdma_queues_per_engine = 8,
> @@ -494,7 +494,7 @@ static const struct kfd_device_info navy_flounder_device_info = {
> .mqd_size_aligned = MQD_SIZE_ALIGNED,
> .needs_iommu_device = false,
> .supports_cwsr = true,
> - .needs_pci_atomics = false,
> + .needs_pci_atomics = true,
> .num_sdma_engines = 2,
> .num_xgmi_sdma_engines = 0,
> .num_sdma_queues_per_engine = 8,
> @@ -512,7 +512,7 @@ static const struct kfd_device_info vangogh_device_info = {
> .mqd_size_aligned = MQD_SIZE_ALIGNED,
> .needs_iommu_device = false,
> .supports_cwsr = true,
> - .needs_pci_atomics = false,
> + .needs_pci_atomics = true,
> .num_sdma_engines = 1,
> .num_xgmi_sdma_engines = 0,
> .num_sdma_queues_per_engine = 2,
> @@ -530,7 +530,7 @@ static const struct kfd_device_info dimgrey_cavefish_device_info = {
> .mqd_size_aligned = MQD_SIZE_ALIGNED,
> .needs_iommu_device = false,
> .supports_cwsr = true,
> - .needs_pci_atomics = false,
> + .needs_pci_atomics = true,
> .num_sdma_engines = 2,
> .num_xgmi_sdma_engines = 0,
> .num_sdma_queues_per_engine = 8,
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
