On Fri, Dec 4, 2020 at 11:49 AM Simon Ser <contact@xxxxxxxxxxx> wrote:
>
> If this function fails, it means the tiling flags didn't make sense.
> This likely indicates a user-space bug. Log the error alongside with the
> provided tiling flags to make debugging easier.
>
> Signed-off-by: Simon Ser <contact@xxxxxxxxxxx>
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Cc: Harry Wentland <hwentlan@xxxxxxx>
> Cc: Nicholas Kazlauskas <nicholas.kazlauskas@xxxxxxx>
> Cc: Bas Nieuwenhuizen <bas@xxxxxxxxxxxxxxxxxxx>
> Cc: Michel Dänzer <michel@xxxxxxxxxxx>
Applied the series. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> index 73b85da2ccbf..e90be2e8eb2a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> @@ -901,8 +901,11 @@ int amdgpu_display_framebuffer_init(struct drm_device *dev,
> if (dev->mode_config.allow_fb_modifiers &&
> !(rfb->base.flags & DRM_MODE_FB_MODIFIERS)) {
> ret = convert_tiling_flags_to_modifier(rfb);
> - if (ret)
> + if (ret) {
> + drm_dbg_kms(dev, "Failed to convert tiling flags 0x%llX to a modifier",
> + rfb->tiling_flags);
> goto fail;
> + }
> }
>
> for (i = 1; i < rfb->base.format->num_planes; ++i) {
> --
> 2.29.2
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
