Am 2020-11-30 um 2:25 p.m. schrieb Alex Deucher: > There are no performance advantages to setting it to 1 and > it causes stability issues in some cases. See my later email on the other thread. There was another consideration besides performance. It had to do with retry fault handling, which depended on being able to reroute the interrupts to the IH1 ring, which the security policy doesn't allow on many boards. With Christian's recent changes to reroute retry interrupts to a software ring, this dependency is gone and it should now be safe to enable retry on most boards. > > v2: simplify the code > > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1374 > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx> Reviewed-by: Felix Kuehling <Felix.Kuehling@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c > index fede84509dbc..b07c47cacd28 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c > @@ -422,11 +422,6 @@ void amdgpu_gmc_noretry_set(struct amdgpu_device *adev) > > switch (adev->asic_type) { > case CHIP_VEGA20: > - case CHIP_NAVI10: > - case CHIP_NAVI14: > - case CHIP_SIENNA_CICHLID: > - case CHIP_NAVY_FLOUNDER: > - case CHIP_DIMGREY_CAVEFISH: > /* > * noretry = 0 will cause kfd page fault tests fail > * for some ASICs, so set default to 1 for these ASICs. _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
