On Tue, Nov 10, 2020 at 11:57 AM Tian Tao <tiantao6@xxxxxxxxxxxxx> wrote: > > Fixes coccicheck warning: > drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c:255: > 36-43: WARNING opportunity for kmemdup > > Signed-off-by: Tian Tao <tiantao6@xxxxxxxxxxxxx> Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c > index 740e2fc..1e79baa 100644 > --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c > +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c > @@ -252,12 +252,11 @@ static int init_powerplay_table_information( > phm_copy_clock_limits_array(hwmgr, &pptable_information->power_saving_clock_max, powerplay_table->PowerSavingClockMax, ATOM_VEGA12_PPCLOCK_COUNT); > phm_copy_clock_limits_array(hwmgr, &pptable_information->power_saving_clock_min, powerplay_table->PowerSavingClockMin, ATOM_VEGA12_PPCLOCK_COUNT); > > - pptable_information->smc_pptable = kmalloc(sizeof(PPTable_t), GFP_KERNEL); > + pptable_information->smc_pptable = kmemdup(&(powerplay_table->smcPPTable), > + sizeof(PPTable_t), GFP_KERNEL); > if (pptable_information->smc_pptable == NULL) > return -ENOMEM; > > - memcpy(pptable_information->smc_pptable, &(powerplay_table->smcPPTable), sizeof(PPTable_t)); > - > result = append_vbios_pptable(hwmgr, (pptable_information->smc_pptable)); > > return result; > -- > 2.7.4 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
