On Thu, 05 Nov 2020, Daniel Vetter wrote: > On Thu, Nov 5, 2020 at 7:10 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote: > > > > On Thu, 05 Nov 2020, Thierry Reding wrote: > > > > > On Thu, Nov 05, 2020 at 02:44:58PM +0000, Lee Jones wrote: > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > kernel builds, which are currently overwhelmingly riddled with > > > > niggly little warnings. > > > > > > > > There are 5000 warnings to work through. > > > > > > > > It will take a couple more sets. > > > > > > > > Lee Jones (19): > > > > gpu: host1x: bus: Add missing description for 'driver' > > > > gpu: ipu-v3: ipu-di: Strip out 2 unused 'di_sync_config' entries > > > > gpu: drm: imx: ipuv3-plane: Mark 'crtc_state' as __always_unused > > > > gpu: drm: omapdrm: omap_irq: Fix a couple of doc-rot issues > > > > gpu: drm: selftests: test-drm_mm: Mark 'hole_end' as always_unused > > > > gpu: drm: scheduler: sched_main: Provide missing description for > > > > 'sched' paramter > > > > gpu: drm: scheduler: sched_entity: Demote non-conformant kernel-doc > > > > headers > > > > gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables > > > > gpu: drm: selftests: test-drm_framebuffer: Remove set but unused > > > > variable 'fb' > > > > gpu: drm: ttm: ttm_bo: Fix one function header - demote lots of > > > > kernel-doc abuses > > > > gpu: drm: panel: panel-simple: Fix 'struct panel_desc's header > > > > gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function > > > > 'analogix_dp_write_byte_to_dpcd' > > > > gpu: drm: ttm: ttm_tt: Demote kernel-doc header format abuses > > > > gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct > > > > drm_dp_sideband_msg_req_body' onto the heap > > > > gpu: drm: radeon: radeon_drv: Remove unused variable 'ret' > > > > gpu: drm: panel: panel-ilitek-ili9322: Demote non-conformant > > > > kernel-doc header > > > > gpu: drm: radeon: radeon_device: Fix a bunch of kernel-doc > > > > misdemeanours > > > > gpu: drm: amd: amdgpu: amdgpu: Mark global variables as __maybe_unused > > > > gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function > > > > 'analogix_dp_start_aux_transaction' > > > > > > As commented on the other patches, the subject prefixes on most of these > > > look wrong, but it's generally a nice cleanup. > > > > The prefixes are automated. I'll add this to my list of awkward > > subsystems and go through them all manually again tomorrow. :D > > tbh for autmoation they look really good :-) Only the prefixes are automated unfortunately. :) > I'd say if you replace the intermediate ": " with just a / you'll be > perfectly in style for drivers/gpu. But really I think it's ok as-is, It's up to you. Make the call and I'll abide. > imo no need to change since this is a giantic tree wide effort. Yes, you're not kidding, and thanks for noticing. Only 10,000 (from 18,000) more to go though. :D GPU is a biggy (5,000), although one patch in [Set 2] fixes 2,000 in one hit, which is great! I'll probably submit that tomorrow. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx