This is an ABI-breaking change. Is any user mode code using this already?
Regards,
Felix
Am 2020-10-28 um 11:22 a.m. schrieb Kent Russell:
> amdgpu's unique_id prints in hex format, so change topology's printout
> to hex by adding a new sysfs_print macro specifically for hex output,
> and use it for unique_id
>
> Signed-off-by: Kent Russell <kent.russell@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> index a3fc23873819..d13c68c52bbc 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> @@ -217,6 +217,8 @@ struct kfd_topology_device *kfd_create_topology_device(
> sysfs_show_gen_prop(buffer, offs, "%s %u\n", name, value)
> #define sysfs_show_64bit_prop(buffer, offs, name, value) \
> sysfs_show_gen_prop(buffer, offs, "%s %llu\n", name, value)
> +#define sysfs_show_64bit_prop_hex(buffer, offs, name, value) \
> + sysfs_show_gen_prop(buffer, offs, "%s %llx\n", name, value)
> #define sysfs_show_32bit_val(buffer, offs, value) \
> sysfs_show_gen_prop(buffer, offs, "%u\n", value)
> #define sysfs_show_str_val(buffer, offs, value) \
> @@ -497,7 +499,7 @@ static ssize_t node_show(struct kobject *kobj, struct attribute *attr,
> dev->node_props.num_sdma_queues_per_engine);
> sysfs_show_32bit_prop(buffer, offs, "num_cp_queues",
> dev->node_props.num_cp_queues);
> - sysfs_show_64bit_prop(buffer, offs, "unique_id",
> + sysfs_show_64bit_prop_hex(buffer, offs, "unique_id",
> dev->node_props.unique_id);
>
> if (dev->gpu) {
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
