Re: [PATCH] drm/amdgpu: Fix size calculation when init onchip memory

[Luben Tuikov <luben.tuikov@xxxxxxx>]

On 2020-10-23 03:12, Christian König wrote:
> Am 23.10.20 um 07:41 schrieb xinhui pan:
>> Size is page count here.
>>
>> Signed-off-by: xinhui pan <xinhui.pan@xxxxxxx>
> 
> Ah yes that one again. At some point we really need to clean that up.
> 
> Patch is Reviewed-by: Christian König <christian.koenig@xxxxxxx>
> 
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>> index 4a85f8cedd77..11dd3d9eac15 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>> @@ -65,11 +65,11 @@
>>   
>>   static int amdgpu_ttm_init_on_chip(struct amdgpu_device *adev,
>>   				    unsigned int type,
>> -				    uint64_t size)
>> +				    uint64_t size_in_page)
>>   {
>>   	return ttm_range_man_init(&adev->mman.bdev, type,
>>   				  TTM_PL_FLAG_UNCACHED, TTM_PL_FLAG_UNCACHED,
>> -				  false, size >> PAGE_SHIFT);
>> +				  false, size_in_page);

Why don't we call this "page_count" or "num_pages"?
"size_in_page" is really confusing and not something people
say and use in English.

Regards,
Luben

>>   }
>>   
>>   /**
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=04%7C01%7Cluben.tuikov%40amd.com%7C868c9232cb924441c02308d8772307e4%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637390339646490801%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=H5r9C%2Bj3zVEsGSDNUlxl1%2Bg7lytcsczO7KpSymIv%2F0E%3D&amp;reserved=0
> 

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx