On Fri, Oct 23, 2020 at 04:21:15PM +0800, Hou, Xiaomeng (Matthew) wrote: > This reverts commit ba502322c9f216552485cea967aeb8adbaf03a02. I suggest you didn't highlight to revert a patch. Becasue previous commit was good before, because it's the gap that firmware/sbios support. Just modify the subject as "drm/amdgpu: enable IP discovery for vangogh", that's enough. With that fixed, patch is Reviewed-by: Huang Rui <ray.huang@xxxxxxx> > > IP discovery table has been verified on vangogh. > > Signed-off-by: Xiaomeng Hou <Xiaomeng.Hou@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/nv.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c > index 72435e0eb8b9..30ec826c8760 100644 > --- a/drivers/gpu/drm/amd/amdgpu/nv.c > +++ b/drivers/gpu/drm/amd/amdgpu/nv.c > @@ -449,10 +449,6 @@ static int nv_reg_base_init(struct amdgpu_device *adev) > { > int r; > > - /* IP discovery table is not available yet */ > - if (adev->asic_type == CHIP_VANGOGH) > - goto legacy_init; > - > if (amdgpu_discovery) { > r = amdgpu_discovery_reg_base_init(adev); > if (r) { > -- > 2.17.1 > _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx