RE: [PATCH] drm/amdgpu: prevent spurious warning

["Russell, Kent" <Kent.Russell@xxxxxxx>]

[AMD Public Use]

Reviewed-by: Kent Russell <kent.russell@xxxxxxx>

 Kent

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Alex Deucher
> Sent: Tuesday, October 6, 2020 9:27 AM
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
> Subject: [PATCH] drm/amdgpu: prevent spurious warning
> 
> The default auto setting for kcq should not generate
> a warning.
> 
> Fixes: a300de40f66b ("drm/amdgpu: introduce a new parameter to configure how many
> KCQ we want(v5)")
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 5a26894dc635..7f26408c0d76 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1372,7 +1372,9 @@ static int amdgpu_device_check_arguments(struct
> amdgpu_device *adev)
> 
>  	amdgpu_gmc_tmz_set(adev);
> 
> -	if (amdgpu_num_kcq > 8 || amdgpu_num_kcq < 0) {
> +	if (amdgpu_num_kcq == -1) {
> +		amdgpu_num_kcq = 8;
> +	} else if (amdgpu_num_kcq > 8 || amdgpu_num_kcq < 0) {
>  		amdgpu_num_kcq = 8;
>  		dev_warn(adev->dev, "set kernel compute queue number to 8 due to
> invalid parameter provided by user\n");
>  	}
> --
> 2.25.4
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.or
> g%2Fmailman%2Flistinfo%2Famd-
> gfx&amp;data=02%7C01%7Ckent.russell%40amd.com%7C4a54f0460acd4e92a43e08d869fb
> 8d14%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637375876466082586&amp;
> sdata=rRpRoxlz6PIjDnhRPFPCom4Nn599DoVRG4Dl5iOlZRE%3D&amp;reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx