|
[AMD Official Use Only - Internal Distribution Only]
Thanks,
.calc_vupdate_position : Used to help avoid cursor stuttering
.set_pipe : Needed for setting abm
WIll add these before pushing.
From: Kazlauskas, Nicholas <Nicholas.Kazlauskas@xxxxxxx>
Sent: October 5, 2020 2:12 PM To: Lakha, Bhawanpreet <Bhawanpreet.Lakha@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx> Cc: rodrigo.siqOFueira@xxxxxxx <rodrigo.siqOFueira@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx> Subject: Re: [PATCH] drm/amd/display: Add missing function pointers for dcn3 On 2020-10-05 2:10 p.m., Bhawanpreet Lakha wrote:
> These function pointers are missing from dcn30_init > > .calc_vupdate_position > .set_pipe > > So add them > > Signed-off-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@xxxxxxx> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@xxxxxxx> Would be good to mention what these are used for specifically though. The calc_vupdate_position in particular is used to help avoid cursor stuttering. Regards, Nicholas Kazlauskas > --- > drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c > index 7c90c2222506..dc312d4172af 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c > +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c > @@ -90,9 +90,11 @@ static const struct hw_sequencer_funcs dcn30_funcs = { > .init_vm_ctx = dcn20_init_vm_ctx, > .set_flip_control_gsl = dcn20_set_flip_control_gsl, > .get_vupdate_offset_from_vsync = dcn10_get_vupdate_offset_from_vsync, > + .calc_vupdate_position = dcn10_calc_vupdate_position, > .apply_idle_power_optimizations = dcn30_apply_idle_power_optimizations, > .set_backlight_level = dcn21_set_backlight_level, > .set_abm_immediate_disable = dcn21_set_abm_immediate_disable, > + .set_pipe = dcn21_set_pipe, > }; > > static const struct hwseq_private_funcs dcn30_private_funcs = { > |
_______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
