Applied. Thanks!
On Mon, Sep 28, 2020 at 10:06 AM Harry Wentland <harry.wentland@xxxxxxx> wrote:
>
> On 2020-09-27 10:36 p.m., Jason Yan wrote:
> > This addresses the following sparse warning:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_hw_sequencer.c:180:26:
> > warning: symbol 'get_color_space_type' was not declared. Should it be
> > static?
> >
>
> If you have multiple fixes of the same or similar nature in the same
> subsystem (e.g. drm/amd/display) I would prefer a single patch to fix
> all of them. These really only need separate patches if they go outside
> a subsystem.
>
> I see a lot of these tiny static checker patches from Huawei and while I
> appreciate small patches I feel these are needlessly small.
>
> > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
>
> Reviewed-by: Harry Wentland <harry.wentland@xxxxxxx>
>
> Harry
>
> > ---
> > drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> > index c026b393f3c5..2a9080400bdd 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> > @@ -177,7 +177,7 @@ static bool is_ycbcr709_limited_type(
> > ret = true;
> > return ret;
> > }
> > -enum dc_color_space_type get_color_space_type(enum dc_color_space color_space)
> > +static enum dc_color_space_type get_color_space_type(enum dc_color_space color_space)
> > {
> > enum dc_color_space_type type = COLOR_SPACE_RGB_TYPE;
> >
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
