On 2020-09-25 4:09 p.m., Alex Deucher wrote: > From: Huang Rui <ray.huang@xxxxxxx> > > This patch adds common ip support for van gogh. > > Signed-off-by: Huang Rui <ray.huang@xxxxxxx> > Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx> > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/nv.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c > index bc894cfba60c..2077f897d6eb 100644 > --- a/drivers/gpu/drm/amd/amdgpu/nv.c > +++ b/drivers/gpu/drm/amd/amdgpu/nv.c > @@ -478,6 +478,9 @@ static int nv_reg_base_init(struct amdgpu_device *adev) > case CHIP_NAVY_FLOUNDER: > sienna_cichlid_reg_base_init(adev); > break; > + case CHIP_VANGOGH: > + vangogh_reg_base_init(adev); > + break; That's gonna throw a warning when compiled, since you're not collecting the return value. As per my email to the previous patch in this sequence, define this function as "void". Regards, Luben > default: > return -EINVAL; > } > @@ -858,6 +861,11 @@ static int nv_common_early_init(void *handle) > adev->external_rev_id = adev->rev_id + 0x32; > break; > > + case CHIP_VANGOGH: > + adev->cg_flags = 0; > + adev->pg_flags = 0; > + adev->external_rev_id = adev->rev_id + 0x01; > + break; > default: > /* FIXME: not supported yet */ > return -EINVAL; > _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
