I don't know much about display code but this is
Acked-by: Nirmoy Das <nirmoy.das@xxxxxxx> as Sonny confirmed that the
revert fixes display corruption.
On 9/11/20 9:35 AM, Christian König wrote:
Ping, we need to revert this ASAP.
Christian.
Am 09.09.20 um 13:16 schrieb Christian König:
Turns out this breaks a lot of different hardware.
This reverts commit 522ff3a8b6d73a31084b4b087b458f7fa0ac1e14.
Signed-off-by: Christian König <christian.koenig@xxxxxxx>
---
drivers/gpu/drm/radeon/radeon_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_display.c
b/drivers/gpu/drm/radeon/radeon_display.c
index 7b69d6dfe44a..e0ae911ef427 100644
--- a/drivers/gpu/drm/radeon/radeon_display.c
+++ b/drivers/gpu/drm/radeon/radeon_display.c
@@ -933,7 +933,7 @@ static void avivo_get_fb_ref_div(unsigned nom,
unsigned den, unsigned post_div,
/* get matching reference and feedback divider */
*ref_div = min(max(den/post_div, 1u), ref_div_max);
- *fb_div = max(nom * *ref_div * post_div / den, 1u);
+ *fb_div = DIV_ROUND_CLOSEST(nom * *ref_div * post_div, den);
/* limit fb divider to its maximum */
if (*fb_div > fb_div_max) {
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cnirmoy.das%40amd.com%7Cf783daab70b74e9eb3f908d856254f13%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637354065561865480&sdata=%2FrEgUz%2FcfFkI4JHMZ9L56UHKDID2zHDRzwwBNrHYNmU%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx