Re: [PATCH 1/1] drm/amdgpu: disable gpu-sched load balance for uvd_enc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alex,


If possible, please squash this with:


commit e0300ed8820d19fe108006cf1b69fa26f0b4e3fc

drm/amdgpu: disable gpu-sched load balance for uvd


Regards,

Nirmoy

On 9/2/20 1:07 PM, Christian König wrote:
Am 02.09.20 um 12:15 schrieb Nirmoy Das:
On hardware with multiple uvd instances, dependent uvd_enc jobs
may get scheduled to different uvd instances. Because uvd_enc
jobs retain hw context, dependent jobs should always run on the
same uvd instance. This patch disables GPU scheduler's load balancer
for a context that binds jobs from the same context to a uvd
instance.

Signed-off-by: Nirmoy Das <nirmoy.das@xxxxxxx>

Reviewed-by: Christian König <christian.koenig@xxxxxxx>

---
  drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
index 7cd398d25498..c80d8339f58c 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
@@ -114,8 +114,10 @@ static int amdgpu_ctx_init_entity(struct amdgpu_ctx *ctx, u32 hw_ip,
      scheds = adev->gpu_sched[hw_ip][hw_prio].sched;
      num_scheds = adev->gpu_sched[hw_ip][hw_prio].num_scheds;

+    /* disable load balance if the hw engine retains context among dependent jobs */
      if (hw_ip == AMDGPU_HW_IP_VCN_ENC ||
          hw_ip == AMDGPU_HW_IP_VCN_DEC ||
+        hw_ip == AMDGPU_HW_IP_UVD_ENC ||
          hw_ip == AMDGPU_HW_IP_UVD) {
          sched = drm_sched_pick_best(scheds, num_scheds);
          scheds = &sched;
--
2.28.0

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Cnirmoy.das%40amd.com%7C14abaffe97944d1732a008d84f306f01%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637346416736947845&amp;sdata=1F8al%2F7xTX2sjhoUI88UNE2mjWPJxNpFslmAuBJjevU%3D&amp;reserved=0

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux