On Fri, Jul 10, 2020 at 1:49 PM Nirmoy Das <nirmoy.aiemd@xxxxxxxxx> wrote:
>
> Fixes: 394e9a14c63d58e0f (drm/amdgpu: Need to set the baco cap before baco reset)
hmmm, this whole thing probably needs to be sorted a bit.
394e9a14c63d58e0f only added the baco cap check for vega10, so we
don't do it for other vega parts. I think we ultimately need to
adjust the logic in soc15_need_reset_on_init() and
nv_need_reset_on_init() to check if the SMU is running rather than the
psp (is the SMU is running the PSP should be as well since the PSP is
required to set up the SMU). Then for the reset at init time, we can
either force mode1 reset (which avoids needing to check of the board
supports BACO), or we need to check the BACO straps and use the
current reset logic.
Alex
>
> Signed-off-by: Nirmoy Das <nirmoy.das@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/soc15.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c
> index 8c739b285915..59c974630991 100644
> --- a/drivers/gpu/drm/amd/amdgpu/soc15.c
> +++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
> @@ -986,9 +986,6 @@ static bool soc15_need_reset_on_init(struct amdgpu_device *adev)
> {
> u32 sol_reg;
>
> - /* Just return false for soc15 GPUs. Reset does not seem to
> - * be necessary.
> - */
> if (!amdgpu_passthrough(adev))
> return false;
>
> --
> 2.27.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
