On Thu, Jul 9, 2020 at 3:15 PM Nirmoy Das <nirmoy.aiemd@xxxxxxxxx> wrote:
>
> Cleanup of phase1 suspend code to reduce unnecessary indentation.
>
> Signed-off-by: Nirmoy Das <nirmoy.das@xxxxxxx>
Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 23 ++++++++++++----------
> 1 file changed, 13 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 2913e41f63a5..81ca92127c00 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2456,18 +2456,21 @@ static int amdgpu_device_ip_suspend_phase1(struct amdgpu_device *adev)
> for (i = adev->num_ip_blocks - 1; i >= 0; i--) {
> if (!adev->ip_blocks[i].status.valid)
> continue;
> +
> /* displays are handled separately */
> - if (adev->ip_blocks[i].version->type == AMD_IP_BLOCK_TYPE_DCE) {
> - /* XXX handle errors */
> - r = adev->ip_blocks[i].version->funcs->suspend(adev);
> - /* XXX handle errors */
> - if (r) {
> - DRM_ERROR("suspend of IP block <%s> failed %d\n",
> - adev->ip_blocks[i].version->funcs->name, r);
> - return r;
> - }
> - adev->ip_blocks[i].status.hw = false;
> + if (adev->ip_blocks[i].version->type != AMD_IP_BLOCK_TYPE_DCE)
> + continue;
> +
> + /* XXX handle errors */
> + r = adev->ip_blocks[i].version->funcs->suspend(adev);
> + /* XXX handle errors */
> + if (r) {
> + DRM_ERROR("suspend of IP block <%s> failed %d\n",
> + adev->ip_blocks[i].version->funcs->name, r);
> + return r;
> }
> +
> + adev->ip_blocks[i].status.hw = false;
> }
>
> return 0;
> --
> 2.27.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
