Looks good to me.
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@xxxxxxx>
Regards,
Nicholas Kazlauskas
On 2020-07-08 10:15 a.m., Deucher, Alexander wrote:
[AMD Public Use]
[AMD Public Use]
Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>
------------------------------------------------------------------------
*From:* Aaron Ma <aaron.ma@xxxxxxxxxxxxx>
*Sent:* Wednesday, July 8, 2020 4:16 AM
*To:* Wentland, Harry <Harry.Wentland@xxxxxxx>; Li, Sun peng (Leo)
<Sunpeng.Li@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>;
Koenig, Christian <Christian.Koenig@xxxxxxx>; airlied@xxxxxxxx
<airlied@xxxxxxxx>; daniel@xxxxxxxx <daniel@xxxxxxxx>;
amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>;
dri-devel@xxxxxxxxxxxxxxxxxxxxx <dri-devel@xxxxxxxxxxxxxxxxxxxxx>;
linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>;
mapengyu@xxxxxxxxx <mapengyu@xxxxxxxxx>; aaron.ma@xxxxxxxxxxxxx
<aaron.ma@xxxxxxxxxxxxx>
*Subject:* [PATCH] drm/amd/display: add dmcub check on RENOIR
RENOIR loads dmub fw not dmcu, check dmcu only will prevent loading iram,
it breaks backlight control.
Bug:
https://bugzilla.kernel.org/show_bug.cgi?id=208277
<https://bugzilla.kernel.org/show_bug.cgi?id=208277>
Signed-off-by: Aaron Ma <aaron.ma@xxxxxxxxxxxxx>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 10ac8076d4f2..db5e0bb0d935 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -1358,7 +1358,7 @@ static int dm_late_init(void *handle)
struct dmcu *dmcu = NULL;
bool ret;
- if (!adev->dm.fw_dmcu)
+ if (!adev->dm.fw_dmcu && !adev->dm.dmub_fw)
return detect_mst_link_for_all_connectors(adev->ddev);
dmcu = adev->dm.dc->res_pool->dmcu;
--
2.25.1
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
