Re: [PATCH] drm/amdgpu: use %u rather than %d for sclk/mclk

[Nirmoy <nirmodas@xxxxxxx>]

Acked-by: Nirmoy Das <nirmoy.das@xxxxxxx>


On 7/1/20 6:02 PM, Alex Deucher wrote:
> Large clock values may overflow and show up as negative.
>
> Reported by prOMiNd on IRC.
>
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> index 26c8e39a78bd..838d6d51904c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> @@ -2960,7 +2960,7 @@ static ssize_t amdgpu_hwmon_show_sclk(struct device *dev,
>   	if (r)
>   		return r;
>   
> -	return snprintf(buf, PAGE_SIZE, "%d\n", sclk * 10 * 1000);
> +	return snprintf(buf, PAGE_SIZE, "%u\n", sclk * 10 * 1000);
>   }
>   
>   static ssize_t amdgpu_hwmon_show_sclk_label(struct device *dev,
> @@ -2997,7 +2997,7 @@ static ssize_t amdgpu_hwmon_show_mclk(struct device *dev,
>   	if (r)
>   		return r;
>   
> -	return snprintf(buf, PAGE_SIZE, "%d\n", mclk * 10 * 1000);
> +	return snprintf(buf, PAGE_SIZE, "%u\n", mclk * 10 * 1000);
>   }
>   
>   static ssize_t amdgpu_hwmon_show_mclk_label(struct device *dev,
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx