Hi, Frederic, On Thu, Jun 18, 2020 at 10:05:19AM +0200, Frederic Barrat wrote: > > > Le 13/06/2020 à 02:41, Fenghua Yu a écrit : > >PASID is defined as "int" although it's a 20-bit value and shouldn't be > >negative int. To be consistent with type defined in iommu, define PASID > >as "unsigned int". > > > It looks like this patch was considered because of the use of 'pasid' in > variable or function names. The ocxl driver only makes sense on powerpc and > shouldn't compile on anything else, so it's probably useless in the context > of that series. > The pasid here is defined by the opencapi specification > (https://opencapi.org), it is borrowed from the PCI world and you could > argue it could be an unsigned int. But then I think the patch doesn't go far > enough. But considering it's not used on x86, I think this patch can be > dropped. The first 3 patches clean up pasid and flag defitions to prepare for following patches. If you think this patch can be dropped, we will drop it. Thanks. -Fenghua _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
