On Mon, May 18, 2020 at 12:37 PM Aishwarya Ramakrishnan <aishwaryarj100@xxxxxxxxx> wrote: > > Return statements in functions returning bool should use > true/false instead of 1/0. > > drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c:40:9-10: > WARNING: return of 0/1 in function 'event_interrupt_isr_v9' with return type bool > > Generated by: scripts/coccinelle/misc/boolreturn.cocci > > Signed-off-by: Aishwarya Ramakrishnan <aishwaryarj100@xxxxxxxxx> Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c b/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c > index e05d75ecda21..fce6ccabe38b 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c > @@ -37,7 +37,7 @@ static bool event_interrupt_isr_v9(struct kfd_dev *dev, > vmid = SOC15_VMID_FROM_IH_ENTRY(ih_ring_entry); > if (vmid < dev->vm_info.first_vmid_kfd || > vmid > dev->vm_info.last_vmid_kfd) > - return 0; > + return false; > > source_id = SOC15_SOURCE_ID_FROM_IH_ENTRY(ih_ring_entry); > client_id = SOC15_CLIENT_ID_FROM_IH_ENTRY(ih_ring_entry); > @@ -69,7 +69,7 @@ static bool event_interrupt_isr_v9(struct kfd_dev *dev, > > /* If there is no valid PASID, it's likely a bug */ > if (WARN_ONCE(pasid == 0, "Bug: No PASID in KFD interrupt")) > - return 0; > + return false; > > /* Interrupt types we care about: various signals and faults. > * They will be forwarded to a work queue (see below). > -- > 2.17.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx