Hi Am 13.05.20 um 11:27 schrieb Emil Velikov: > On Tue, 12 May 2020 at 20:48, Alex Deucher <alexdeucher@xxxxxxxxx> wrote: > >>>>> >>>>> There's some AGP support code in the DRM core. Can some of that declared >>>>> as legacy? >>>>> >>>>> Specifically, what about these AGP-related ioctl calls? Can they be >>>>> declared as legacy? It would appear to me that KMS-based drivers don't >>>>> have to manage AGP by themselves. (?) >>>> >>>> The old drm core AGP code is mainly (only?) for the non-KMS drivers. >>>> E.g., mach64, r128, sis, savage, etc. >>> >>> Exactly my point. There's one drm_agp_init() call left in radeon. The >>> rest of the AGP code is apparently for legacy non-KMS drivers. Should >>> the related ioctl calls be declared as legacy (i.e., listed with >>> DRM_LEGACY_IOCTL_DEF instead of DRM_IOCTL_DEF)? If so, much of the AGP >>> core code could probably be moved behind CONFIG_DRM_LEGACY as well. >> >> Ah, I forgot about drm_agp_init(). I was just thinking the other AGP >> stuff. Yeah, I think we could make it legacy. >> > Fwiw I've got local patches a) removing drm_agp_init() from radeon and > b) making the core drm code legacy only. > Will try to finish them over the weekend and send out. > > Even if AGP GART gets dropped the b) patches will be good ;-) Fantastic! Please see one of my other comments in this thread. There's still drm_agp_init() somewhere in radeon_drv.c. So patch a) might still be useful. Best regards Thomas > > -Emil > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ amd-gfx mailing list amd-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/amd-gfx
