RE: [PATCH] Series to disallow XGMI link power down during RAS XGMI error injection

["Chen, Guchun" <Guchun.Chen@xxxxxxx>]

[AMD Public Use]

 

Patch 1,

1. maybe it’s better to split it into 2, one is for header file change, and another is functional patch.

2.  Can below codes be merged to one return instead? Variable ‘en’ can serve the function input in smu_send_smc_msg_with_param.

 

if (en)

+                           return smu_send_smc_msg_with_param(smu,

+                                                                                       SMU_MSG_GmiPwrDnControl,

+                                                                                       1,

+                                                                                       NULL);

+

+            return smu_send_smc_msg_with_param(smu,

+                                                                         SMU_MSG_GmiPwrDnControl,

+                                                                         0,

+                                                                         NULL);

 

Patch 2: Reviewed-by: Guchun Chen guchun.chen@xxxxxxx

 

Patch 3:

1.function amdgpu_ras_error_inject_xgmi should be one static function?

2. Regarding below return case, is there one dpm_allow_xgmi_power_down leak? As we have disabled xgmi link power down.

 

+            if (amdgpu_ras_intr_triggered())

+                           return ret;

 

Regards,

Guchun

 

From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Clements, John
Sent: Friday, May 8, 2020 2:51 PM
To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Zhang, Hawking <Hawking.Zhang@xxxxxxx>
Subject: [PATCH] Series to disallow XGMI link power down during RAS XGMI error injection

 

[AMD Official Use Only - Internal Distribution Only]

 

Submitting 3 patches for review:

• Added host to SMU FW cmd to enable/disable XGMI link power down
• Added DPM function for XGMI link power down control
• Disable XGMI link power down prior to issuing a XGMI RAS error

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx